tag:blogger.com,1999:blog-5028009537158799436.post8261416769199603983..comments2023-07-10T04:50:03.236-07:00Comments on Building Real Software: Don’t waste time on Code ReviewsJim Birdhttp://www.blogger.com/profile/17371102366836131341noreply@blogger.comBlogger8125tag:blogger.com,1999:blog-5028009537158799436.post-62401647180769733122018-03-09T00:21:19.161-08:002018-03-09T00:21:19.161-08:00Great post !Great post !Rémi BOURGARELhttps://www.blogger.com/profile/04893916371648676071noreply@blogger.comtag:blogger.com,1999:blog-5028009537158799436.post-22026616213858510272014-12-19T05:49:23.594-08:002014-12-19T05:49:23.594-08:00Thoughts: newer developers should review code to s...Thoughts: newer developers should review code to see if it is too advanced or complex to support. And perhaps as a learning/measuring tool at that - what is appropriate in terms of complexity in design and what training is needed so that newer developers can be utilized.@philn5dhttps://www.blogger.com/profile/13741152072729675553noreply@blogger.comtag:blogger.com,1999:blog-5028009537158799436.post-61870816046865561472014-08-27T08:24:27.133-07:002014-08-27T08:24:27.133-07:00Idunno ...
We put quite a handful of reviewers on...Idunno ...<br /><br />We put quite a handful of reviewers on a change set, but which aren't <i>required</i> to do the review. Some do, some don't, but in the end it all levels up - change sets do get reviewed by more than one person.<br /><br />I do like noobs doing code reviews - it's one of the few ways to get fresh viewpoints on your codebase and coding style. Of course, a senior dev should always review each change set, but sometimes noobs have insights that seniors don't have.<br /><br />Besides, noobs doing reviews is an excellent learning tool, and not at all time wasted, even if all they do is asking questions.<br />A_flj_https://www.blogger.com/profile/13123052099912825525noreply@blogger.comtag:blogger.com,1999:blog-5028009537158799436.post-40675175140965424692014-08-25T09:20:17.029-07:002014-08-25T09:20:17.029-07:00Another study on code reviews at VMware, confirmin...Another study on code reviews at VMware, confirming that Mozilla projects and most VMware projects require 2 code reviewers.<br />https://labs.vmware.com/download/198/<br />And the importance of having informed reviewers: "Mozilla projects require that at least one of the reviewers must be the module owner or the module owner's peer. In VMware, there is no company-wide policy regarding the assignment of reviewers. However many projects do follow conventions similar to Mozilla projects." Jim Birdhttps://www.blogger.com/profile/17371102366836131341noreply@blogger.comtag:blogger.com,1999:blog-5028009537158799436.post-77632119271900313892014-08-24T13:24:19.782-07:002014-08-24T13:24:19.782-07:00Thank You<a href="http://downloadsoftware-ar.blogspot.com/" rel="nofollow">Thank</a> <a href="http://downloadprogames1.blogspot.com/" rel="nofollow">You</a>Anonymousnoreply@blogger.comtag:blogger.com,1999:blog-5028009537158799436.post-4348015374427530992014-08-22T12:51:33.582-07:002014-08-22T12:51:33.582-07:00Hmm.. I more or less agree, however I do see some ...Hmm.. I more or less agree, however I do see some value if new team members hear the discussion of experienced members about the code. It is a way to learn about the team ethics. And that might not show up in the "more bugs found" statistic, but in the "code was reviewed and somebody learned new things" departement.Berndhttp://itblog.eckenfels.netnoreply@blogger.comtag:blogger.com,1999:blog-5028009537158799436.post-30030367134486099882014-08-22T06:27:11.206-07:002014-08-22T06:27:11.206-07:00"during" not "on" is what your..."during" not "on" is what your article is about. Unless of course you meant to be controversial in your title. <br /><br />That being said, I did a quick read. What I saw, I [mostly?] agree. The days of printing out your code and meeting in a big room to review code are behind us. Mark Nuttallhttps://www.blogger.com/profile/11521440812448315535noreply@blogger.comtag:blogger.com,1999:blog-5028009537158799436.post-23071941268929197572014-08-20T11:14:44.080-07:002014-08-20T11:14:44.080-07:00Yes, you've pretty well covered it!
My take-a...Yes, you've pretty well covered it!<br /><br />My take-aways, straight out of this post:<br /><br />1. Static analysis to find the easy stuff<br />2. Put the best people on code review<br />3. Focus on what really matters: correctness issues, and things that make the code harder to understand and harder to maintainTom Harrishttp://talkaboutquality.wordpress.com/noreply@blogger.com